Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dark mode #73

Closed
mdolr opened this issue Oct 6, 2020 · 9 comments
Closed

Add support for dark mode #73

mdolr opened this issue Oct 6, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Milestone

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 6, 2020

Add the possibility to switch the survol div to dark mode.

Tasks :

  • Add a setting in the settings popup to toggle dark mode
  • Change the CSS to have a dark mode maybe using css variables ?
@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 6, 2020
@dmb1107
Copy link

dmb1107 commented Oct 6, 2020

Can you assign this to me so I can give it a go?

@KeshriAyushi22
Copy link

Hey can you assign this to me aswell, It will be a good learning for me

@mdolr
Copy link
Owner Author

mdolr commented Oct 7, 2020

Hum I’m confused, a PR has already been made ( #74 )

@KeshriAyushi22
Copy link

@mdolr sure, if any help required i would be happy to contribute

@mdolr
Copy link
Owner Author

mdolr commented Oct 7, 2020

Then I guess you should take a look at the PR 👍

@mdolr mdolr linked a pull request Oct 7, 2020 that will close this issue
@KeshriAyushi22
Copy link

KeshriAyushi22 commented Oct 8, 2020 via email

@mdolr
Copy link
Owner Author

mdolr commented Oct 8, 2020

It should be applied when a switch in the popup window (settings when clicking on icon) is checked

@KeshriAyushi22
Copy link

image
@mdolr i will change the color scheme , just wanted to check whether this is okay

@mdolr mdolr added this to the Next release milestone Oct 8, 2020
@mdolr
Copy link
Owner Author

mdolr commented Oct 9, 2020

@dmb1107 @KeshriAyushi22 I've implemented a dark mode if you want to see how I've done it you can check the last commits. In the first commit I've started by unifying the CSS has there were some inconsistencies (fc5f590).

Then in the 2nd one I've implemented the dark mode (69cc547)

@mdolr mdolr closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants