Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small changes #241

Merged
merged 9 commits into from
May 16, 2024
Merged

Various small changes #241

merged 9 commits into from
May 16, 2024

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Apr 5, 2024

Purpose

  • Changes the hard-coded lower bound for the triangulated surface constraint from a dummy value of -1e10 to None which is the correct way to represent that there is no lower bound.
  • Converts the SVD vectors computed when using composite DVs from a numpy matrix to a numpy array. Using a matrix causes the design variable values to end up as a 2D array which causes pyoptsparse to fail.
  • Fixes a check in addRefAxis that is supposed to evaluate to false is x/y/zFraction is None, but currently also evaluates to False is the values are zero.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner April 5, 2024 15:07
@A-CGray A-CGray requested review from anilyil and sseraj April 5, 2024 15:07
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.47%. Comparing base (20f491a) to head (1707057).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files          47       47           
  Lines       12265    12265           
=======================================
  Hits         8030     8030           
  Misses       4235     4235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sseraj
sseraj previously approved these changes Apr 5, 2024
@A-CGray A-CGray requested review from ArshSaja and removed request for anilyil April 5, 2024 17:10
pygeo/parameterization/DVGeo.py Outdated Show resolved Hide resolved
pygeo/parameterization/DVGeo.py Show resolved Hide resolved
@A-CGray A-CGray requested review from eirikurj and sseraj April 29, 2024 16:53
@ArshSaja ArshSaja merged commit 4c762ab into main May 16, 2024
12 checks passed
@marcomangano marcomangano deleted the defaultBounds branch May 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants