Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LE radius projection #235

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fixed LE radius projection #235

merged 1 commit into from
Jan 29, 2024

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Jan 22, 2024

Purpose

The projection to the leading edge for the LE radius constraint currently projects points to the LE and TE even though only the LE point is used. @bernardopacini found that the TE projection can sometimes fail. Following @anilyil's suggestion, I changed the projection to only project to the LE.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

The existing LE radius constraint tests pass.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner January 22, 2024 18:28
@sseraj sseraj requested review from hajdik and marcomangano January 22, 2024 18:28
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bbcdf0) 65.18% compared to head (4d577f5) 65.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   65.18%   65.30%   +0.12%     
==========================================
  Files          47       47              
  Lines       12123    12122       -1     
==========================================
+ Hits         7902     7916      +14     
+ Misses       4221     4206      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sseraj sseraj merged commit 86caa3b into main Jan 29, 2024
12 checks passed
@sseraj sseraj deleted the radius-proj branch January 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants