Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume projection bounds #221

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Volume projection bounds #221

merged 7 commits into from
Sep 26, 2023

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Sep 9, 2023

Purpose

This PR adds the capability to set parametric bounds in the embedding volume of each FFD box. This is useful to control the behavior of overlapping FFDs, where the user wants to avoid embedding any point in one portion of one or both of the FFDs.

This PR needs changes in mdolab/pyspline#63 to work.

Expected time until merged

After mdolab/pyspline#63 is merged.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner September 9, 2023 02:15
@anilyil anilyil requested review from marcomangano, sseraj, hajdik and lamkina and removed request for marcomangano and sseraj September 9, 2023 02:15
Copy link
Contributor

@lamkina lamkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to go. We had to trigger the CI checks and tests manually on Azure so they are not showing up here, but they all passed.

@hajdik
Copy link
Contributor

hajdik commented Sep 26, 2023

I can't merge it with the failures, @anilyil can you do it?

@anilyil anilyil merged commit e6c1746 into mdolab:main Sep 26, 2023
1 of 9 checks passed
@anilyil anilyil deleted the vol_bounds branch September 26, 2023 18:01
@sseraj
Copy link
Collaborator

sseraj commented Sep 26, 2023

Did anyone actually run this on Azure? The tests are failing

@anilyil
Copy link
Contributor Author

anilyil commented Sep 26, 2023

I am on it. That previous run was probably not right

@anilyil anilyil mentioned this pull request Sep 26, 2023
13 tasks
@lamkina
Copy link
Contributor

lamkina commented Sep 26, 2023

Did anyone actually run this on Azure? The tests are failing

We tried to manually run an Azure and accidentally ran the wrong PR and didn't realize it.

@sseraj
Copy link
Collaborator

sseraj commented Sep 26, 2023

Ah okay, I see that manual run. For future reference, the checks in PRs should be updated even if you manually run the pipeline (as long as it's the correct commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants