-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume projection bounds #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to go. We had to trigger the CI checks and tests manually on Azure so they are not showing up here, but they all passed.
I can't merge it with the failures, @anilyil can you do it? |
Did anyone actually run this on Azure? The tests are failing |
I am on it. That previous run was probably not right |
We tried to manually run an Azure and accidentally ran the wrong PR and didn't realize it. |
Ah okay, I see that manual run. For future reference, the checks in PRs should be updated even if you manually run the pipeline (as long as it's the correct commit). |
Purpose
This PR adds the capability to set parametric bounds in the embedding volume of each FFD box. This is useful to control the behavior of overlapping FFDs, where the user wants to avoid embedding any point in one portion of one or both of the FFDs.
This PR needs changes in mdolab/pyspline#63 to work.
Expected time until merged
After mdolab/pyspline#63 is merged.
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable