Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shape function DVs #202

Merged
merged 16 commits into from
Jun 6, 2023
Merged

Add shape function DVs #202

merged 16 commits into from
Jun 6, 2023

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented May 17, 2023

Purpose

This PR adds generic shape function DVs to the DVGeo class. This way, the users can specify shape functions that determine what FFD control point will move in what direction. A single shape function can affect multiple FFD points. A single FFD point can be affected by multiple shape functions; the displacements from each shape function are superposed. This also adds shape function DVs to the MPhys wrapper.

No tests yet, but wanted to create the PR to get the ball rolling.

Expected time until merged

2 weeks

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner May 17, 2023 03:01
@anilyil anilyil requested review from hajdik and sseraj May 17, 2023 03:01
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #202 (830c329) into main (45be339) will decrease coverage by 0.03%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   64.78%   64.76%   -0.03%     
==========================================
  Files          47       47              
  Lines       11969    12018      +49     
==========================================
+ Hits         7754     7783      +29     
- Misses       4215     4235      +20     
Impacted Files Coverage Δ
pygeo/mphys/mphys_dvgeo.py 0.00% <0.00%> (ø)
pygeo/parameterization/designVars.py 78.64% <72.22%> (-0.62%) ⬇️
pygeo/parameterization/DVGeo.py 68.78% <75.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil
Copy link
Contributor Author

anilyil commented May 24, 2023

This one is ready to be reviewed @hajdik, @sseraj. Maybe also @bernardopacini because you guys used this for the aviation paper.

@hajdik
Copy link
Contributor

hajdik commented May 26, 2023

I added the MPhys wrapper function from my branch.

pygeo/mphys/mphys_dvgeo.py Outdated Show resolved Hide resolved
tests/reg_tests/test_DVGeometry.py Outdated Show resolved Hide resolved
pygeo/parameterization/DVGeo.py Outdated Show resolved Hide resolved
pygeo/parameterization/DVGeo.py Outdated Show resolved Hide resolved
pygeo/parameterization/DVGeo.py Outdated Show resolved Hide resolved
pygeo/parameterization/DVGeo.py Outdated Show resolved Hide resolved
@anilyil anilyil requested a review from sseraj June 5, 2023 19:32
sseraj
sseraj previously approved these changes Jun 5, 2023
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation changes look good

examples/c172_wing/runFFDExample.py Outdated Show resolved Hide resolved
pygeo/parameterization/designVars.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hajdik hajdik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sseraj sseraj merged commit 4f18d04 into mdolab:main Jun 6, 2023
@anilyil anilyil deleted the shape_funcs branch August 29, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants