Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nom_addProjectedAreaConstraint and allow non-scaled area/volume constraints #196

Merged
merged 3 commits into from
May 11, 2023

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Apr 28, 2023

Purpose

As-per the title

Expected time until merged

1-2 weeks

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner April 28, 2023 15:08
@A-CGray A-CGray requested review from hajdik and anilyil April 28, 2023 15:08
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #196 (0e34746) into main (7ca8f36) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   64.87%   64.86%   -0.02%     
==========================================
  Files          47       47              
  Lines       11941    11944       +3     
==========================================
  Hits         7747     7747              
- Misses       4194     4197       +3     
Impacted Files Coverage Δ
pygeo/mphys/mphys_dvgeo.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil anilyil merged commit ba53e25 into main May 11, 2023
@anilyil anilyil deleted the addMPhysFuncs branch May 11, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants