New functions in MPhys wrapper #193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 64.87% 64.78% -0.09%
==========================================
Files 47 47
Lines 11953 11969 +16
==========================================
Hits 7754 7754
- Misses 4199 4215 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pygeo/mphys/mphys_dvgeo.py
Outdated
| if self.geo_type != "ffd": | ||
| raise RuntimeError(f"Only FFD-based DVGeo objects can use local DVs, not type:{self.geo_type}") | ||
|
|
||
| # add the DV to a child DVGeo |
There was a problem hiding this comment.
isn't this comment backwards?
|
Lucas is testing this with his case, don't merge until we double check that it's good there. |
hajdik
changed the title
|
I added other functions I've been needing in MPhys to this PR and updated the info. Lucas said local shape variables have been working for him so I think everything is good to go. |
|
This PR is still ready for review and now has docstrings, by popular demand. |
|
From today's maintenance meeting, we decided to remove methods from the MPhys wrapper that do not add input / outputs for OpenMDAO (with the exception of adding a reference axis). Instead, we should add a method that just returns the DVGeo object so the user can directly interface with the underlying object methods. |
…phys-localsectiondv
These changes have been addressed. |
There was a problem hiding this comment.
Actually, can you add the ref axis call back? Just because that is a critical routine that is almost always called with FFDs. It does affect the outputs of DVGeo, but not OM states.
Most other routines are just utility functions that help with i/o or get indices etc, so they can be accessed through the DVGeo object.
Purpose
Adding addLocalSectionDVs to the MPhys wrapper and adding ways to return the geometry component's DVCon and DVGeo (or child DVGeo) objects so the user can use each class's methods directly
Expected time until merged
2 months
Type of change
Testing
soon
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable