-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add triangulated surface constraint to MPhys wrapper #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 64.79% 64.75% -0.04%
==========================================
Files 47 47
Lines 11957 11964 +7
==========================================
Hits 7747 7747
- Misses 4210 4217 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! Just a few minor questions.
Noting that PR #191 affects this one (or vice versa, depending on which is merged first). We can go ahead and merge this and I can update that one.
I am good with this, though I cam not a pyGeo maintainer so I cannot merge it. Whoever is (@mdolab/pygeo_maintainers), please go ahead and merge this in. |
Purpose
This adds
TriangulatedSurfaceConstraint
tomphys_dvgeo
so packaging constraints (GeoGrad) can be used in MPhys and cleans up a few things related to that constraint in DVCon. The GeoGrad fail flag, which skips CFD if the intersection between the two objects exceeds the tolerance, has also been exposed to the MPhys wrapper using OpenMDAO'sAnalysisError
. The parallelism fix in #191 was also done for this constraint.Unrelated to this constraint, a few missing options were added into existing constraints in the MPhys wrapper.
Expected time until merged
1 week
Type of change
Testing
I have a runscript modified from an old MACH runscript that runs as expected with MPhys in place of MACH. If someone wants to use it in a docker container I can pass that and the input files along.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable