Sparse Jacobians for DVGeometryMulti #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I changed the total Jacobian computation in DVGeometryMulti to use sparse matrices instead of dense matrices. I followed one of SciPy's recommended approaches by using
lil_matrix
for construction and then converting tocsr_matrix
for faster arithmetic. This approach required minimal changes to the code.The memory usage was not dramatically different for the cases I tested because the Jacobian is usually not very sparse. Still, the memory used by the sparse Jacobian was about 60% of the memory used by the dense Jacobian for the largest case I tested (around 140k surface points and 270 geometric DVs).
Expected time until merged
1 week
Type of change
Testing
The current DVGeometryMulti test passes, which shows that the derivatives are still correct.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable