Fixing import errors, adding isort, cleaned up regression tests, and added unit tests for new import procedure. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 64.61% 64.74% +0.12%
==========================================
Files 47 47
Lines 11954 11941 -13
==========================================
+ Hits 7724 7731 +7
+ Misses 4230 4210 -20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sseraj
requested changes
Feb 2, 2023
marcomangano
requested changes
Feb 2, 2023
|
|
||
| @ignore_warnings | ||
| def test__DVGeometryVSP_import_openvsp(self): | ||
| with patch.dict(sys.modules, {"openvsp": None}): |
There was a problem hiding this comment.
This took me a long time to figure out.
| import warnings | ||
|
|
||
|
|
||
| def ignore_warnings(test_func): |
There was a problem hiding this comment.
Yeah you can see my comment above, but this is because numpy is annoying for these tests.
marcomangano
approved these changes
Feb 2, 2023
sseraj
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the following features:
DVGeometryESP,DVGeometryVSP,DVGeometryMulti, andDVGeometryCSTall have optional dependencies required to function properly. Previously, pyGeo suppressed the import errors leaving users confused as to why their code wasn't working with pyGeo. In this PR, the import suppression was replaced in favor of logic control in the import statements that will throw an error if the user tries to initialize any of the classes listed above. Using this new procedure, the correct errors will be thrown with descriptions when the user tries to use one of the classes, without suppression..isort.cfgfile here to the root of the the pyGeo repo. I added iSort the the azure pipeline yaml file as well.This PR will close issue #176
Expected time until merged
This is a quality of life PR, so not urgent. I would estimate a few weeks or less to merge.
Type of change
Testing
To test the new changes, run the new unit tests with either pyTest or testflo.
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable