Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #164

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Update README.md #164

merged 5 commits into from
Oct 31, 2022

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Oct 27, 2022

Purpose

The readme didn't have all the parameterization options or the right year

Expected time until merged

fast

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik marked this pull request as ready for review October 27, 2022 01:03
@hajdik hajdik requested a review from a team as a code owner October 27, 2022 01:03
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #164 (a941087) into main (2905061) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   63.93%   63.92%   -0.01%     
==========================================
  Files          47       47              
  Lines       11819    11818       -1     
==========================================
- Hits         7556     7555       -1     
  Misses       4263     4263              
Impacted Files Coverage Δ
pygeo/constraints/baseConstraint.py 57.22% <ø> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcomangano
Copy link
Contributor

It looks like we need to pin one of flake8 sub packages?

@ewu63
Copy link
Collaborator

ewu63 commented Oct 27, 2022

It's a valid complaint, I think we should probably fix it.

marcomangano
marcomangano previously approved these changes Oct 31, 2022
@marcomangano
Copy link
Contributor

How are we taking care of the flake8 fixes?

sseraj
sseraj previously approved these changes Oct 31, 2022
@sseraj
Copy link
Collaborator

sseraj commented Oct 31, 2022

I removed addVariablesPyOpt from baseConstraint because only ColinearityConstraint implements this method (which makes sense because most constraints don't have their own DVs).

@marcomangano marcomangano merged commit b078e3c into main Oct 31, 2022
@marcomangano marcomangano deleted the update-readme branch October 31, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants