Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyGeo specific contribution information #161

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Add pyGeo specific contribution information #161

merged 1 commit into from
Oct 18, 2022

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Oct 18, 2022

Purpose

Add a link from the pyGeo docs to the general MACH contribution guide page as well as pyGeo specific information

Expected time until merged

1 day, very simple addition

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik requested a review from a team as a code owner October 18, 2022 17:51
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #161 (6ba70d4) into main (022e6b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files          47       47           
  Lines       11819    11819           
=======================================
  Hits         7556     7556           
  Misses       4263     4263           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ArshSaja
Copy link
Contributor

approved

@ewu63 ewu63 merged commit bb27e51 into main Oct 18, 2022
@ewu63 ewu63 deleted the contribute-doc branch October 18, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants