Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed wrapper code for deprecated routines #146

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jul 21, 2022

Purpose

I removed the old wrapper functions, which were introduced in #91 over a year ago. We should make the minor release once this is merged.

Expected time until merged

Should not take more than 1-2 days.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

None.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner July 21, 2022 21:16
@ewu63 ewu63 requested review from hajdik and marcomangano July 21, 2022 21:16
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #146 (25e73fe) into main (511e70c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   63.72%   63.75%   +0.03%     
==========================================
  Files          47       47              
  Lines       11679    11667      -12     
==========================================
- Hits         7442     7438       -4     
+ Misses       4237     4229       -8     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeo.py 64.64% <ø> (+0.18%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hajdik hajdik merged commit d786ca8 into main Jul 22, 2022
@hajdik hajdik deleted the remove-deprecation branch July 22, 2022 13:37
@bernardopacini bernardopacini mentioned this pull request Jul 26, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants