-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP Version Update #132
Merged
Merged
ESP Version Update #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to esp-version-update
…to esp-version-update
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
===========================================
- Coverage 62.60% 47.44% -15.17%
===========================================
Files 43 43
Lines 11207 11207
===========================================
- Hits 7016 5317 -1699
- Misses 4191 5890 +1699
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Merging this since it won't pass without Docker changes. |
ewu63
approved these changes
Apr 7, 2022
12 tasks
marcomangano
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Added the topID key for the mphys's LETE constraint. This is needed for airfoil cases. * reverting disallow skip change in #132 Co-authored-by: Sabet Seraj <48863473+sseraj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Updating calls to the ESP python interface to align with the new version that will be used in the docker images. This new version eliminates the need to maintain our own patched version.
This will fail because the docker image has not been updated yet.
Expected time until merged
So fast, please
Type of change
Testing
Local DVGeoESP tests pass
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted