Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP Version Update #132

Merged
merged 9 commits into from
Apr 7, 2022
Merged

ESP Version Update #132

merged 9 commits into from
Apr 7, 2022

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Apr 7, 2022

Purpose

Updating calls to the ESP python interface to align with the new version that will be used in the docker images. This new version eliminates the need to maintain our own patched version.

This will fail because the docker image has not been updated yet.

Expected time until merged

So fast, please

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Local DVGeoESP tests pass

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik requested a review from a team as a code owner April 7, 2022 19:54
@hajdik hajdik requested review from joanibal and anilyil April 7, 2022 19:54
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #132 (66581c7) into main (5057ede) will decrease coverage by 15.16%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##             main     #132       +/-   ##
===========================================
- Coverage   62.60%   47.44%   -15.17%     
===========================================
  Files          43       43               
  Lines       11207    11207               
===========================================
- Hits         7016     5317     -1699     
- Misses       4191     5890     +1699     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeoMulti.py 0.40% <0.00%> (-89.42%) ⬇️
pygeo/parameterization/DVGeoESP.py 0.95% <5.55%> (-64.54%) ⬇️
pygeo/constraints/areaConstraint.py 50.50% <100.00%> (-25.42%) ⬇️
pygeo/constraints/radiusConstraint.py 80.00% <100.00%> (ø)
pygeo/constraints/thicknessConstraint.py 82.50% <100.00%> (ø)
pygeo/geo_utils/rotation.py 49.47% <100.00%> (ø)
pygeo/parameterization/DVGeoAxi.py 77.21% <100.00%> (ø)
pygeo/pyBlock.py 45.37% <100.00%> (-1.65%) ⬇️
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ewu63
Copy link
Collaborator

ewu63 commented Apr 7, 2022

Merging this since it won't pass without Docker changes.

@ewu63 ewu63 merged commit fdcfe8b into mdolab:main Apr 7, 2022
@hajdik hajdik deleted the esp-version-update branch April 8, 2022 01:15
marcomangano pushed a commit that referenced this pull request Apr 18, 2022
* Added the topID key for the mphys's LETE constraint. This is needed for airfoil cases.

* reverting disallow skip change in #132

Co-authored-by: Sabet Seraj <48863473+sseraj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants