Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug for composite DV #129

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Fixed bug for composite DV #129

merged 6 commits into from
Mar 23, 2022

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Mar 23, 2022

Purpose

Apparently, I had hard-coded the initial DVs to zero. I didn't care at the time because in all my tests, the initial DVs happen to be zero anyways. But now I fixed it so it computes the correct initial DVs.

Also, I changed getValues() to return real values instead of complex. It didn't make sense to me to return any complex DVs, and I'm pretty sure the ESP/VSP versions will always return real values. The tests should all pass, and I'm somewhat confident in this change because getValues() is not really used internally in DVGeo. But maintainers please double check that this works.

Expected time until merged

ASAP

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

N/A

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner March 23, 2022 23:10
@ewu63 ewu63 requested review from hajdik and marcomangano March 23, 2022 23:10
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #129 (96853e1) into main (fa469af) will increase coverage by 0.00%.
The diff coverage is 55.55%.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   62.55%   62.56%           
=======================================
  Files          43       43           
  Lines       11182    11186    +4     
=======================================
+ Hits         6995     6998    +3     
- Misses       4187     4188    +1     
Impacted Files Coverage Δ
pygeo/parameterization/DVGeo.py 64.31% <50.00%> (+0.02%) ⬆️
pygeo/parameterization/designVars.py 74.87% <50.00%> (ø)
pygeo/__init__.py 89.47% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

anilyil
anilyil previously approved these changes Mar 23, 2022
Copy link
Contributor

@anilyil anilyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bug fix looks good. I like the getValues change but I am not sure if it would break anybody's workflow? Maybe some people are getting the values this was resolved offline

Copy link
Contributor

@anilyil anilyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR's so good I had to approve it twice

@ewu63 ewu63 merged commit 0e2f4fd into main Mar 23, 2022
@ewu63 ewu63 deleted the fix-comp-x0 branch March 23, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants