Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mphys wrapper #120

Merged
merged 5 commits into from
Mar 23, 2022
Merged

adding mphys wrapper #120

merged 5 commits into from
Mar 23, 2022

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Mar 11, 2022

Purpose

This PR adds the MPhys wrapper for DVGeo. See the discussion of a similar PR in ADflow: mdolab/adflow#196

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner March 11, 2022 22:53
@anilyil anilyil requested review from joanibal and hajdik March 11, 2022 22:53
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #120 (cfb57d6) into main (bf9b4eb) will decrease coverage by 11.79%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #120       +/-   ##
===========================================
- Coverage   63.40%   51.60%   -11.80%     
===========================================
  Files          41       43        +2     
  Lines       11033    11182      +149     
===========================================
- Hits         6995     5771     -1224     
- Misses       4038     5411     +1373     
Impacted Files Coverage Δ
pygeo/mphys/__init__.py 0.00% <0.00%> (ø)
pygeo/mphys/mphys_dvgeo.py 0.00% <0.00%> (ø)
pygeo/parameterization/DVGeoMulti.py 0.40% <0.00%> (-89.42%) ⬇️
pygeo/constraints/areaConstraint.py 50.50% <0.00%> (-25.42%) ⬇️
pygeo/constraints/DVCon.py 66.56% <0.00%> (-3.80%) ⬇️
pygeo/pyBlock.py 45.37% <0.00%> (-1.65%) ⬇️
pygeo/parameterization/DVGeo.py 63.79% <0.00%> (-0.50%) ⬇️
pygeo/topology.py 54.92% <0.00%> (-0.23%) ⬇️
pygeo/__init__.py 100.00% <0.00%> (+10.52%) ⬆️
pygeo/parameterization/__init__.py 100.00% <0.00%> (+14.28%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

joanibal
joanibal previously approved these changes Mar 21, 2022
@joanibal
Copy link
Collaborator

Don't forget to fix linting error

hajdik
hajdik previously approved these changes Mar 21, 2022
@anilyil anilyil dismissed stale reviews from hajdik and joanibal via e5f1a47 March 21, 2022 21:34
@anilyil
Copy link
Contributor Author

anilyil commented Mar 23, 2022

If this looks good can someone merge this? I guess I cannot merge myself because I am not a maintainer here? I will add tests and clean the implementation a bit in future PRs.

@ewu63 ewu63 merged commit b23ccb5 into mdolab:main Mar 23, 2022
@anilyil anilyil deleted the add_mphys branch March 23, 2022 16:08
@anilyil anilyil mentioned this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants