Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed paths to code in docs #443

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Fixed paths to code in docs #443

merged 3 commits into from
Aug 4, 2024

Conversation

eytanadler
Copy link
Collaborator

Purpose

The test file locations were moved in a previous PR, which broke code blocks in the docs. This PR fixes the paths so they appear again.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner August 2, 2024 16:05
@eytanadler eytanadler requested review from lamkina, kanekosh and A-CGray and removed request for lamkina August 2, 2024 16:05
Copy link
Contributor

@kanekosh kanekosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eytan. I should've caught this when I reviewed, my bad.

Could you also update the paths in other files:

  • quick_example.rst
  • struct_example.rst
  • aerostruct_tube_walkthrough.rst
  • advanced_features/aerostruct_ffd.rst
  • advanced_features/ground_effect.rst
  • advanced_features/multiple_surfaces.rst
  • advanced_features/multipoint.rst

I think this is all but I might've missed something

@eytanadler eytanadler requested a review from kanekosh August 2, 2024 18:29
@eytanadler
Copy link
Collaborator Author

Is this good to merge?

@kanekosh kanekosh merged commit 87edebd into mdolab:main Aug 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants