Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to Azure #438

Merged
merged 16 commits into from
Jul 19, 2024
Merged

Move CI to Azure #438

merged 16 commits into from
Jul 19, 2024

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Jul 19, 2024

Purpose

The current github action for running the OAS tests is a bit of a mess, it tries to build OpenMPI, PETSc and OpenVSP, and it uses "latest" and "old" package versions that don't match the rest of our packages. It would be much cleaner if we could run the OAS CI jobs on our docker containers where we have working environments with all the dependencies OAS needs and with stable and latests versions of things that match our other packages.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner July 19, 2024 15:56
@A-CGray A-CGray requested review from kanekosh and eytanadler July 19, 2024 15:56
@A-CGray A-CGray requested a review from eirikurj July 19, 2024 15:58
@eirikurj
Copy link
Contributor

Added the pipeline, it should start soon.

@A-CGray
Copy link
Member Author

A-CGray commented Jul 19, 2024

The VSP test is failing because the vsp file it depends on isn't moved to the python installation directory but the tests are because they're inside the openaerostruct package directory. I think we should move all the tests out of the package directory into their own top level directory like we do for all our other packages

@A-CGray A-CGray mentioned this pull request Jul 19, 2024
13 tasks
@kanekosh kanekosh merged commit 410b523 into main Jul 19, 2024
3 of 9 checks passed
@A-CGray A-CGray deleted the GHAImprovement branch July 19, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants