Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to prevent OpenMDAO from suppressing tecplot file writing #427

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

timryanb
Copy link
Contributor

Purpose

Prevents OpenMDAO from suppressing MPhys postprocessing components when using group_by_pre_opt_post feature.

Expected time until merged

a week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • [ x] Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

…ng when using `group_by_pre_opt_post` feature
@timryanb timryanb requested a review from a team as a code owner April 23, 2024 14:53
@eytanadler
Copy link
Collaborator

What changes in mphys 2.0 will be incompatible with this interface? We’ve been seeing the codecov connection errors a lot lately. I think you did some debugging last time you ran into it (thank you), but still no luck.

@timryanb
Copy link
Contributor Author

What changes in mphys 2.0 will be incompatible with this interface? We’ve been seeing the codecov connection errors a lot lately. I think you did some debugging last time you ran into it (thank you), but still no lucI don't

What changes in mphys 2.0 will be incompatible with this interface? We’ve been seeing the codecov connection errors a lot lately. I think you did some debugging last time you ran into it (thank you), but still no luck.

The changes in 2.0 will mostly be related to import restructuring and moving to enum classes to define MPhys vars. You can find a beta for the version here.

I'm not all that familiar with codecov, so I don't have any good answers for whats causing the issue.

Copy link
Collaborator

@eytanadler eytanadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then the upper bound won't be too challenging to fix once 2.0 is released. We've merged the past couple PRs as long as they pass the tests even if codecov fails. I'll try running again, but merge anyway if codecov still fails.

@eytanadler eytanadler merged commit d788e11 into mdolab:main Apr 29, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants