Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function from plot_wing take 2 #409

Merged
merged 2 commits into from
May 15, 2023

Conversation

eytanadler
Copy link
Collaborator

Purpose

Addresses #407 by replacing cr.system_options with cr.list_model_options(). PR #406 should be merged first.

Expected time until merged

A week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner May 9, 2023 15:31
@eytanadler eytanadler requested review from lamkina and kanekosh May 9, 2023 15:31
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #409 (36a7ec7) into main (dcdb76b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         103      103           
  Lines        6412     6412           
=======================================
  Hits         6058     6058           
  Misses        354      354           
Impacted Files Coverage Δ
openaerostruct/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kanekosh kanekosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eytan, looks good to me. Could you also make the same fixes in plot_wingbox.py?

@eytanadler
Copy link
Collaborator Author

Thanks Eytan, looks good to me. Could you also make the same fixes in plot_wingbox.py?

Good catch. Just updated it

@eytanadler eytanadler requested a review from kanekosh May 15, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants