Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mandala): remove rotation and color animation #9916

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 31, 2023

Summary

Fixes #9347.

Problem

The Mandala animations have two problems:

  1. The rotation causes a significant CPU and GPU usage (see issue above).
  2. The color animation on the MDN Plus page distracts from the content.

Solution

Remove the rotation and the color animation.


Screenshots

Before

Screen.Recording.2023-10-31.at.15.57.16.mov
Screen.Recording.2023-10-31.at.15.57.25.mov

After

Screen.Recording.2023-10-31.at.15.56.59.mov
Screen.Recording.2023-10-31.at.15.57.38.mov

How did you test this change?

Ran yarn && yarn dev and opened http://localhost:3000/en-US/ and http://localhost:3000/en-US/plus locally.

@caugner caugner added the ux make the user experience awesome label Oct 31, 2023
@caugner caugner requested a review from a team as a code owner October 31, 2023 14:59
@github-actions github-actions bot added plus work around features related to MDN Plus plus:updates plus:ai-help labels Oct 31, 2023
Copy link

@AnujaRajput727 AnujaRajput727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the screenshot look OK!

@caugner caugner merged commit e687a03 into main Oct 31, 2023
14 checks passed
@caugner caugner deleted the remove-mandala-animation branch October 31, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plus:ai-help plus:updates plus work around features related to MDN Plus ux make the user experience awesome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU and CPU intensive animation on AI Help page and homepage
2 participants