Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/HTMLSidebar): update zh-CN translation of HTMLSidebar #9790

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jasonren0403
Copy link
Contributor

Summary

the same as title

part of mdn/translated-content#13881

cc: @yin1999 @awxiaoxian2020

Problem

some zh-CN sidebar strings is missing in HTMLSidebar

Solution

add the missing keys and update existing ones to improve consistency

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Oct 11, 2023
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jasonren0403 👍

@caugner caugner merged commit 8bf7a7e into mdn:main Oct 11, 2023
9 checks passed
@caugner
Copy link
Contributor

caugner commented Oct 11, 2023

Thank you @jasonren0403 and @yin1999! 🎉

@jasonren0403 jasonren0403 deleted the patch-1 branch October 11, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants