Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): move toc to left on large screens #9772

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Oct 5, 2023

Summary

Move the blog ToC to the left on large screens.


Screenshots

Before

image

After

image


How did you test this change?

Locally

@fiji-flo fiji-flo requested a review from caugner October 5, 2023 11:31
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed to to submit on Thursday.

@@ -801,7 +802,7 @@ kbd {
display: flex;
flex-direction: column;
gap: 0;
height: calc(100vh - var(--sticky-header-with-actions-height));
height: calc(100vh - var(--offset));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an unrelated fix?

@@ -810,7 +811,7 @@ kbd {
);
overflow: auto;
position: sticky;
top: var(--sticky-header-with-actions-height);
top: var(--offset);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dito

@caugner caugner merged commit 002bddd into main Oct 9, 2023
14 checks passed
@caugner caugner deleted the update-blog-toc branch October 9, 2023 18:57
@caugner caugner added the blog label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants