Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): update zh-CN translation of LearnSidebar #9630

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

jasonren0403
Copy link
Contributor

Summary

the same as title

part of mdn/translated-content#13881

cc: @yin1999 @awxiaoxian2020

Problem

some zh-CN sidebar strings is missing in learn area sidebar

Solution

add the missing keys and update existing ones to improve consistency


Screenshots

Before

After


How did you test this change?

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 11, 2023
kumascript/macros/LearnSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/LearnSidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/LearnSidebar.ejs Outdated Show resolved Hide resolved
jasonren0403 and others added 2 commits September 11, 2023 19:21
Co-authored-by: A1lo <yin199909@aliyun.com>
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @jasonren0403 👍

@jasonren0403
Copy link
Contributor Author

cc @mdn/core-dev for a look 👀

@awxiaoxian2020
Copy link
Contributor

@yin1999 It seems ping @mdn/core-dev doesn't work with @jasonren0403 's permission. I notice that the "ping" is not bolded.

@yin1999
Copy link
Member

yin1999 commented Oct 10, 2023

@yin1999 It seems ping @mdn/core-dev doesn't work with @jasonren0403's permission. I notice that the "ping" is not bolded.

Hey @awxiaoxian2020. @mention is only visible to organization members, I believe jasonren0403 correctly notified the dev team.

@jasonren0403
Copy link
Contributor Author

Hey @awxiaoxian2020. @mention is only visible to organization members, I believe jasonren0403 correctly notified the dev team.

I have, but the dev team still haven't replied 🤔

@jasonren0403
Copy link
Contributor Author

try pinging @LeoMcA for a look 👀

@caugner caugner merged commit 41ec69a into mdn:main Oct 10, 2023
10 checks passed
@caugner
Copy link
Contributor

caugner commented Oct 10, 2023

Sorry for the long wait, and thank you for these improvements! 🙌

@jasonren0403 jasonren0403 deleted the patch-1 branch October 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants