fix(client/public): avoid global variable

[mtrucc]

Summary

Fixes #9597

Problem

Unreasonable global variables 'c'

Solution

yari/client/public/index.html

Line 112 in 231d6aa

const c = { light: "#ffffff", dark: "#1b1b1b" };

Replace the global variable named 'c' to 'themeConfig'

---

Screenshots

Before

After

---

How did you test this change?

Open developer tools

Enter the following command in the console

let a = 1
let b = 2
let c = 3

No error reported

[LeoMcA]

I'd leave the variable as-is, but instead wrap the whole contents of the script tag in an IIFE

You also need to update the CSP hash as explained in the comment at the top of the script

[mtrucc]

I'd leave the variable as-is, but instead wrap the whole contents of the script tag in an IIFE

You also need to update the CSP hash as explained in the comment at the top of the script

Thanks for the tip
I modified the following:

1. Restored variable naming
2. Wrap the whole contents of the script tag in an IIFE
3. Update the CSP hash

[caugner]

Thank you, LGTM! 🙌

[caugner]

@mtrucc Please have a look at the failing "Commit signatures" check:

❌ PR contains 2 unverified commit(s)!

Please note that we require that all commits are signed.
Please see the documentation about signed commits and how to sign yours on GitHub:

• https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
• https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Once you have set up commit signatures, you can sign your existing commits:

git rebase main --exec "git commit --amend --gpg-sign --no-edit"

Then you will need to force-push your branch once:

git push --force

[mtrucc]

@mtrucc Please have a look at the failing "Commit signatures" check:

❌ PR contains 2 unverified commit(s)!
Please note that we require that all commits are signed.
Please see the documentation about signed commits and how to sign yours on GitHub:

• https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification
• https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Once you have set up commit signatures, you can sign your existing commits:
git rebase main --exec "git commit --amend --gpg-sign --no-edit"
Then you will need to force-push your branch once:
git push --force

I'm so sorry I didn't notice this
I usually use GitHub Desktop to submit code
but i didn't set
git config --global commit.gpgsign true
Thank you for your reminder

[caugner]

@mtrucc It looks like you just ran git merge main or similar after enabling commit.gpgsign.

Can you please run git rebase main --exec "git commit --amend --gpg-sign --no-edit" once, which should re-sign your first two commits, and then git push --force? 🙏

[mtrucc]

@mtrucc It looks like you just ran git merge main or similar after enabling commit.gpgsign.

Can you please run git rebase main --exec "git commit --amend --gpg-sign --no-edit" once, which should re-sign your first two commits, and then git push --force? 🙏

The command has been executed. Please try it again. Thanks.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[mtrucc]

The PR contained in contains 2 unverified commits
Do a fork and commit again
#9619