Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): translate command_line in Japanese #8256

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Feb 18, 2023

Summary

@schalkneethling @caugner
cc @hmatrjp @potappo

Problem

still en-us only

Solution

tranlate japanese for LearnSidebar.ejs

NOTICE

please mdn/translated-content#11745 will be merged after review and approve, this PR merge.

Before

still en-us only

After

add tranlate japanese for LearnSidebar.ejs

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Feb 18, 2023
@gurezo gurezo marked this pull request as ready for review February 22, 2023 14:52
@gurezo
Copy link
Contributor Author

gurezo commented Feb 22, 2023

Hi @schalkneethling @caugner
mdn/translated-content#11745 had merged.
please this PR review.

thanks regards

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you, @gurezo !

@wbamberg wbamberg merged commit ac1a07b into mdn:main Feb 23, 2023
@gurezo gurezo deleted the issue/679/commnd-line-crash-course branch September 21, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants