fix(client): sticky header leaves 1px gap on top #11644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to reproduce in BrowserStack Live at 1920x970 on Windows 11 with Chrome 128 consistently at zoom level 75% (but not at 67% / 80% / 90%), and with Firefox 130 once at zoom level 67% (but not at other zoom levels). The |
caugner
reviewed
Sep 27, 2024
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
OnkarRuikar
commented
Sep 28, 2024
| @@ -355,7 +355,7 @@ sup.new { | |||
|
|
|||
| .sticky-header-container { | |||
| position: sticky; | |||
| top: 0; | |||
| top: -0.1px; | |||
There was a problem hiding this comment.
Suggested change
| top: -0.1px; | |
| top: -1px; |
The -0.1px doesn't work on Firefox developer 131.0b9 (64-bit) at 300% zoom on Linux Mint 22 x86_64:
zoomIssue.mp4
It's a rounding error, so it is better to use a complete pixel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depending on the zoom level, the
sticky-header-containerleaves a 1px gap on the top.Problem
Refer to the following video:
stiky_header_1px_gap.mp4
Note that the viewport's top border has white dots.
Make sure you have the dark theme on. If you can not reproduce it, change the browser zoom level slightly and scroll so that some text reaches the top border of the viewport. Keep changing zoom till you see the gap. I can reproduce this in Firefox and Chrome.
Solution
This is due to some zoom levels producing fractions in the header dimensions, so a 1px gap remains after rounding. Pulling the header 1px up by using
top: -1pxshould cover the gap.How did you test this change?
In a browser before and after the fix.