Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/WebExtExamples): add zh translations #11377

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

jasonren0403
Copy link
Contributor

Summary

add zh-CN and zh-TW localization of WebExtExamples macro

zh-TW localization of "WebExtension" is referenced here

/cc @mdn/yari-content-zh

@jasonren0403 jasonren0403 requested a review from a team as a code owner June 28, 2024 04:39
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jun 28, 2024
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

kumascript/macros/WebExtExamples.ejs Outdated Show resolved Hide resolved
Co-authored-by: A1lo <yin199909@aliyun.com>
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jasonren0403

@caugner caugner changed the title chore(macros/WebExtExamples): add l10-zh translation for WebExtExamples macro chore(macros/WebExtExamples): add zh translations Jul 1, 2024
@caugner caugner merged commit 5492bba into mdn:main Jul 1, 2024
10 checks passed
@jasonren0403 jasonren0403 deleted the patch-3 branch July 1, 2024 11:52
ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
* chore(macros/WebExtExamples): add l10-zh translation for WebExtExample

* Apply suggestions from code review

Co-authored-by: A1lo <yin199909@aliyun.com>

---------

Co-authored-by: A1lo <yin199909@aliyun.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants