Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(sidebar,toc): improve style of current item #11063

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 3, 2024

Summary

(MP-1105)

Problem

  1. The borders aren't rounded, unlike other elements.
  2. The items take up all available width.

Solution

  1. Round the right borders.
  2. Reduce the width.

Screenshots

Before After
image image

How did you test this change?

Ran yarn dev and viewed http://localhost:3000/en-US/docs/Learn/CSS/First_steps#guides locally, comparing it against https://developer.mozilla.org/en-US/docs/Learn/CSS/First_steps#guides.

@caugner caugner requested a review from a team as a code owner May 3, 2024 12:29
@caugner caugner added the ux make the user experience awesome label May 3, 2024
@caugner caugner marked this pull request as draft May 20, 2024 16:21
@caugner caugner marked this pull request as draft May 20, 2024 16:21
@caugner caugner marked this pull request as ready for review May 20, 2024 16:32
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit 2e15a84 into main Jul 9, 2024
15 checks passed
@caugner caugner deleted the enhance-current-item-in-sidebar-and-toc branch July 9, 2024 17:43
ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
* enhance(sidebar): round border of current item

* enhance(toc): round border of current item

* enhance(sidebar): reduce width of current item

* enhance(sidebar): add padding-right

* enhance(toc): reduce width of current item

* fix(curriculum): reduce width of current sidebar item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux make the user experience awesome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants