fix(macros/AccessibilitySidebar): remove deleted Annotations page #11040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, Onkar! This created about 150 flaws. 🥳 |
caugner
changed the title
caugner
approved these changes
Apr 30, 2024
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The macro throws a confusing flaw:
Error: wrong xref macro used (consider changing which macro you use)Issue
The error is thrown by smartLink function because the document
Web/Accessibility/ARIA/Annotationshas been deleted and redirects to parent dir.Solution
Remove the deleted doc from the sidebar.
Also, the smartLink function should throw error with message related to the actual issue and not the cryptic one saying wrong macro usage. Changing smartLink function may break other macros and effort will be significant, so let's fix it another day.
Testing
Tested using local dev before and after fix.