fix(css): transparent images in dark mode issue #9863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Oooo crud, yup, let's get this one merged. Thanks @OnkarRuikar!
Damn, I don't have privs to merge on this repo either. Can you handle this one @caugner, or maybe @Rumyra? |
caugner
requested changes
Oct 24, 2023
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR #9250 caused a regression. It changed background color of all the images from
whitetotransparent. Now all the transparent images inmdn/contentare facing issues in dark mode: black lines, black text, and black boxes are appearing invisible.Problem
Set page in dark mode.
Before the regression: https://web.archive.org/web/20230601124043/https://developer.mozilla.org/en-US/docs/Web/Performance/Animation_performance_and_frame_rate#the_rendering_waterfall
After the regression: https://developer.mozilla.org/en-US/docs/Web/Performance/Animation_performance_and_frame_rate#the_rendering_waterfall
Before regression:
After regression:
Solution
It is not feasible to make all the images compatible with both white and black backgrounds. Also, after the regression it is not easy to identify all the images that are affected by transparent background. We can't prevent future contributors from committing transparent illustrations.
It's better to keep the image background white. To solve original issue of alt text, set
color: blackon images.Screenshots
Before
After
Alt text scenario
How did you test this change?
In local browser after doing
yarn dev.