fix(package): run render:html on prepack #11368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that `index.html` files are built and packaged.
ferdnyc
pushed a commit
to ferdnyc/yari
that referenced
this pull request
Jul 13, 2024
* fix(npm-published-simulation): curl with --fail * fix(package): run render:html on prepack Ensures that `index.html` files are built and packaged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11365.
Problem
Since #10953,
yarn tool spasno longer buildsindex.htmlfiles, and these are instead built viayarn render:html, but this command isn't run when packaging yari for npm.Solution
Run
yarn render:htmlas part of theprepackscript.How did you test this change?
Fixed the
npm-published-simulation.ymlworkflow to actually fail when http://localhost:5042/en-US/ returns an HTTP error.