Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yari build possibly broken #11365

Closed
3 tasks done
estelle opened this issue Jun 25, 2024 · 4 comments · Fixed by #11368
Closed
3 tasks done

Yari build possibly broken #11365

estelle opened this issue Jun 25, 2024 · 4 comments · Fixed by #11368
Assignees
Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases. wx writer experience

Comments

@estelle
Copy link
Member

estelle commented Jun 25, 2024

Summary

I updated my local environment.
I can get to http://localhost:5042/en-US/docs (which redirects to http://localhost:5042/en-US/docs/Web)
but not to http://localhost:5042 or http://localhost:5042/en-US or http://localhost:5042/en-US/play/ (live examples work, but clicking "play" to open in new tab gets the error)

The error message reads:

Error: ENOENT: no such file or directory, stat 'myPath/content/node_modules/@mdn/yari/client/build/en-us/_spas/404.html'

It was working on 2.56, but the 2.57 build seems to be the issue.

URL

http://localhost:5042

Reproduction steps

  1. update all the repose
  2. yarn install; yarn start
  3. go to the local environment's MDN home page.

Expected behavior

the home page

Actual behavior

an error:
Error: ENOENT: no such file or directory

Device

Desktop

Browser

Edge

Browser version

Stable

Operating system

iOS

Screenshot

Screenshot 2024-06-25 at 11 47 19 AM
Screenshot 2024-06-25 at 11 48 05 AM

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 25, 2024
@caugner caugner added p1 We will address this soon and will provide capacity from our team for it in the next few releases. wx writer experience and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 25, 2024
@caugner
Copy link
Contributor

caugner commented Jun 25, 2024

Technically, we're missing a yarn render:html when packaging yari, but originally it seems yarn tool spas no longer building HTML files is a breaking change we missed. We'll provide a fix in the next 24 hours.

@caugner
Copy link
Contributor

caugner commented Jun 26, 2024

@estelle The fix is now available in @mdn/yari 2.58.0, and I expect Dependabot to open a PR on mdn/content in the next hours.

@caugner
Copy link
Contributor

caugner commented Jun 26, 2024

With mdn/content#34426 being merged, the fix has now landed in the content repository.

@estelle
Copy link
Member Author

estelle commented Jun 26, 2024

@caugner Thanks for the quick turn around and fix. It's working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases. wx writer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants