fix(baseline): not appearing on translated docs (#9662)

also fixes translated docs not having a `browserCompat` key in their
index/metadata.json

build/index.ts

@@ -217,9 +217,13 @@ export async function buildDocument(
   let flaws: any[] = [];
   let $: cheerio.CheerioAPI = null;
   const liveSamples: LiveSample[] = [];
+  // this will get populated with the parent's frontmatter by kumascript if the document is localized:
+  let allMetadata = metadata;
 
   try {
-    [$, flaws] = await kumascript.render(document.url);
+    let kumascriptMetadata;
+    [$, flaws, kumascriptMetadata] = await kumascript.render(document.url);
+    allMetadata = { ...allMetadata, ...kumascriptMetadata };
   } catch (error) {
     if (
       error instanceof MacroInvocationError &&
@@ -369,7 +373,9 @@ export async function buildDocument(
   doc.mdn_url = document.url;
   doc.locale = metadata.locale as string;
   doc.native = LANGUAGES.get(doc.locale.toLowerCase())?.native;
-  const browserCompat = metadata["browser-compat"];
+
+  // metadata doesn't have a browser-compat key on translated docs:
+  const browserCompat = allMetadata["browser-compat"];
   doc.browserCompat =
     browserCompat &&
     (Array.isArray(browserCompat) ? browserCompat : [browserCompat]);

kumascript/index.ts

@@ -38,14 +38,14 @@ export async function render(
     invalidateCache = false,
   }: RenderOptions = {},
   doc?: Doc
-): Promise<[cheerio.CheerioAPI, SourceCodeError[]]> {
+): Promise<[cheerio.CheerioAPI, SourceCodeError[], any]> {
   const urlLC = url.toLowerCase();
   if (renderCache.has(urlLC)) {
     if (invalidateCache) {
       renderCache.delete(urlLC);
     } else {
       const [renderedHtml, errors] = renderCache.get(urlLC);
-      return [cheerio.load(renderedHtml), errors];
+      return [cheerio.load(renderedHtml), errors, undefined];
     }
   }
 
@@ -135,5 +135,5 @@ export async function render(
       allErrors,
     ]);
   }
-  return [tool.cheerio(), allErrors];
+  return [tool.cheerio(), allErrors, metadata];
 }