Skip to content

Fix the example with Firefox on macOS when managed storage isn't available. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix the example with Firefox on macOS when managed storage isn't available. #554

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a61ba3
Fix the storage.sync part of the example with Firefox on macOS when m…
Dalzhim Feb 9, 2024
b2e1f8d
Suggestion from feedback
rebloor Nov 1, 2024
80bc914
Merge branch 'main' into main
rebloor Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions favourite-colour/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@ async function saveOptions(e) {
}

async function restoreOptions() {
let res = await browser.storage.managed.get('colour');
document.querySelector("#managed-colour").innerText = res.colour;
try {
let res = await browser.storage.managed.get('colour');
document.querySelector("#managed-colour").innerText = res.colour || "Could not find 'colour' in managed storage.";
} catch(error) {
if (error.message === "Managed storage manifest not found") {
document.querySelector("#managed-colour").innerText = "Managed storage manifest not found. Make sure it's stored in an appropriate location.";
} else {
document.querySelector("#managed-colour").innerText = `Unexpected managed storage error: ${error.message}`;
}
}

res = await browser.storage.sync.get('colour');
document.querySelector("#colour").value = res.colour || 'Firefox red';
Expand Down
Loading