Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of {{CompatibilityTable}} from API #864

Merged
merged 1 commit into from
May 23, 2021

Conversation

alattalatta
Copy link
Member

This PR replaces all {{CompatibilityTable}} and its component macros in API references to {{Compat}}. See #858 for HTML, and #859 for CSS.

@alattalatta alattalatta requested a review from a team as a code owner May 14, 2021 18:23
@alattalatta alattalatta requested review from yechoi42 and removed request for a team May 14, 2021 18:23
@tristantheb tristantheb added the l10n-ko Issues related to Korean content. label May 15, 2021
@alattalatta alattalatta force-pushed the api-browser-compat branch from c7dffc5 to 918d34f Compare May 18, 2021 10:10
@alattalatta alattalatta force-pushed the api-browser-compat branch from 918d34f to 51fdf3d Compare May 19, 2021 08:37
Copy link
Member

@yechoi42 yechoi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러 파일 수정하느라 수고 많으셨습니다! 모두 잘 반영된 것 확인했습니다.

처음 몇개의 코멘트의 경우
스크린샷 2021-05-23 오후 6 59 26
매크로를 사용할 경우 안내문을 hidden으로 넣어달라는 문구가 있어서 추가했는데요. (참고 https://developer.mozilla.org/ko/docs/MDN/Structures/Compatibility_tables)

en-US의 경우에도 안넣은 건 마찬가지라서, suggested-changes를 반영할지는 직접 결정해주시면 될 것 같습니다!

@@ -119,58 +119,7 @@ <h2 id="Specifications">Specifications</h2>

<h2 id="Browser_compatibility">Browser compatibility</h2>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="hidden">
<p>The compatibility table on this page is generated from structured data.
If you'd like to contribute to the data, please check out
<a href="https://github.com/mdn/browser-compat-data">https://github.com/mdn/browser-compat-data</a>
and send us a pull request.</p>
</div>

@@ -82,58 +82,7 @@ <h2 id="Specifications">Specifications</h2>

<h2 id="Browser_compatibility">Browser compatibility</h2>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="hidden">
<p>The compatibility table on this page is generated from structured data.
If you'd like to contribute to the data, please check out
<a href="https://github.com/mdn/browser-compat-data">https://github.com/mdn/browser-compat-data</a>
and send us a pull request.</p>
</div>

</tbody>
</table>
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="hidden">
<p>The compatibility table on this page is generated from structured data.
If you'd like to contribute to the data, please check out
<a href="https://github.com/mdn/browser-compat-data">https://github.com/mdn/browser-compat-data</a>
and send us a pull request.</p>
</div>

@alattalatta
Copy link
Member Author

alattalatta commented May 23, 2021

안녕하세요 @yechoi42 님, 그 메시지는 WYSIWYG 에디터가 살아있던 시절 위키 편집하는 사람들 보라고 넣었던건데, 이제 편집환경이 달라졌으니 굳이 붙이지 않아도 될 것 같아요. en-US에 저 메시지 안붙이는 문서가 늘어나고 있는 것도 이런 흐름으로 볼 수 있겠습니다.

@yechoi42
Copy link
Member

안녕하세요 @yechoi42 님, 그 메시지는 WYSIWYG 에디터가 살아있던 시절 위키 편집하는 사람들 보라고 넣었던건데, 이제 편집환경이 달라졌으니 굳이 붙이지 않아도 될 것 같아요. en-US에 저 메시지 안붙이는 문서가 늘어나고 있는 것도 이런 흐름으로 볼 수 있겠습니다.

네 확인했습니다 답변 감사합니다 :) 반영하지 않고 이대로 머지하겠습니다 !

@yechoi42 yechoi42 merged commit 325cdb7 into mdn:main May 23, 2021
@alattalatta alattalatta deleted the api-browser-compat branch May 23, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants