Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Translation done of AudioNode document #3080

Merged
merged 7 commits into from
Dec 28, 2021

Conversation

logic-finder
Copy link
Contributor

@logic-finder logic-finder commented Nov 12, 2021

https://developer.mozilla.org/ko/docs/Web/API/AudioNode
https://developer.mozilla.org/en-US/docs/Web/API/AudioNode
기존 문서는 오래된 문서이고 번역이 불완전해서, 문서를 최신화하고 새로 번역하였습니다.
더불어 설명에 사용되는 사진도 그림판을 사용해 한글화했습니다.
webaudiobasics

@logic-finder logic-finder requested a review from a team as a code owner November 12, 2021 20:20
@logic-finder logic-finder requested review from yechoi42 and removed request for a team November 12, 2021 20:20
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Nov 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2021

Preview URLs

Flaws

URL: /ko/docs/Web/API/AudioNode
Title: AudioNode
on GitHub
Flaw count: 9

  • macros:
    • /ko/docs/Web/API/OscillatorNode does not exist but fallbacked on /en-US/docs/Web/API/OscillatorNode
    • /ko/docs/Web/API/ConvolverNode does not exist but fallbacked on /en-US/docs/Web/API/ConvolverNode
    • /ko/docs/Web/API/GainNode does not exist but fallbacked on /en-US/docs/Web/API/GainNode
    • /ko/docs/Web/API/AudioNode/channelCountMode does not exist but fallbacked on /en-US/docs/Web/API/AudioNode/channelCountMode
    • /ko/docs/Web/API/AudioNode/channelCountMode does not exist but fallbacked on /en-US/docs/Web/API/AudioNode/channelCountMode
    • and 4 more flaws omitted

External URLs

URL: /ko/docs/Web/API/AudioNode
Title: AudioNode
on GitHub

(this comment was updated 2021-12-17 05:21:57.277355)

add comma to the sentence
Copy link
Member

@yechoi42 yechoi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요:) logic-finder 님. 사소한 수정을 몇가지 더했는데, 확인해보시고 저를 다시 멘션해주세요 !

files/ko/web/api/audionode/index.md Outdated Show resolved Hide resolved
files/ko/web/api/audionode/index.md Outdated Show resolved Hide resolved
files/ko/web/api/audionode/index.md Outdated Show resolved Hide resolved
@yechoi42
Copy link
Member

yechoi42 commented Nov 30, 2021

첫번째 커밋부터 PR 테스트도 계속 fail 하더라구요. 이것도 수정 부탁드리겠습니다 ! 이미지 파일 용량 문제인 듯한데... 용량 줄여서 올려봐주실 수 있나요?
image

logic-finder and others added 5 commits December 17, 2021 14:06
Co-authored-by: Yeji Choi <61399588+yechoi42@users.noreply.github.com>
Co-authored-by: Yeji Choi <61399588+yechoi42@users.noreply.github.com>
Co-authored-by: Yeji Choi <61399588+yechoi42@users.noreply.github.com>
@yechoi42
Copy link
Member

yechoi42 commented Dec 28, 2021

안녕하세요 @logic-finder 님 :) 기존 파일에 번역 기여된 것은 없으므로, 이 파일의 첫 기여로 보고 squash merge하겠습니다.

@yechoi42 yechoi42 merged commit 9dda785 into mdn:main Dec 28, 2021
@logic-finder logic-finder deleted the ko_AudioNode branch December 29, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants