-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete Node.isSupported
method
#16996
Remove obsolete Node.isSupported
method
#16996
Conversation
Preview URLs (8 pages)Flaws (197)URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (10)URL:
URL:
URL:
URL:
URL:
URL:
(comment last updated: 2023-11-18 22:13:35) |
Node.isSupported
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for l10n-fr
, thank you @leon-win !
(It may be easier/faster to remove all obsolete methods in one locale in each PR, instead of removing one obsolete method for all locales, because only one reviewer would be needed for each PR.)
@cw118 thank you for reply! I also wanted to do exactly that at first. |
I agree that the changes are very small for all locales, but it happens somewhat often that locales have different conventions and requests, so even for this type of PR we prefer to wait for approval from a reviewer for each locale. Thanks for understanding! |
I'm understood, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for es
As @cw118 says, sometimes is better a PR per locale, so the locale can be updated soon, and then you can identify older locales that maybe ended hidden. Other times is good to have a unified change of all locales in a PR, we respect each locale lead so we wait to their review, depends on the change after two weeks someone more of the core team could approve the whole PR
Thank you so much for all your work and time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for zh-CN
. Thank you @leon-win
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for RU
Thanks for the explanation, @Graywolf9 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for pt-BR
Description
This PR remove obsolete
Node.isSupported
method from MDN translated content.Motivation
It has been removed from en-US locale a long time ago.
Related issues and pull requests
Relates to mdn/content#22863, #13499