Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): make scan usable with npx command #90

Closed
wants to merge 1 commit into from

Conversation

tamascsaba
Copy link

Description

Add bin to package.json to make to be compatible with the npx command, enabling users to run the scan tool directly from the command line.

Motivation

I would like to run observatory locally or in CI :)

@tamascsaba tamascsaba requested review from mdn-bot and a team as code owners September 13, 2024 12:24
Copy link
Contributor

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@argl
Copy link
Contributor

argl commented Sep 16, 2024

Thanks for taking the time to submit your PR, very much appreciated. I tested it out and unfortunately it did not work on my system. But the issue is very much valid, so I did this PR today, which basically does the same thing. Let me know if this fixes your issues.

@tamascsaba
Copy link
Author

tamascsaba commented Sep 17, 2024

The fix is perfect, I haven't had time to test it. 👍

npm supports github repository so it is possible to run with this command:

npx mdn/mdn-http-observatory mdn.dev

but It would be really great, if you could publish this package to the npm registry as well.

@tamascsaba tamascsaba closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants