fix(api): error messages #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMcA
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Code looks fine, I'll point out one thing: I think the error message we show in UI also comes from this error message, the value of having the host in the message is the user sees what the specific host observatory can't resolve is (which is important, because it gets processed a bit, e.g. an input of https://example.com/foobar turns into example.com). Perhaps the error should just be genericised on the frontend, before being sent to glean, or the host should be sent as a separate field in the error response. Or you decide this isn't a problem - also acceptable, just wanted to point it out
…frontend for glean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error message should be generic, this removes host names from the resolver error.
(MP-1397)
Motivation
These get forwarded to telemetry, so these should be only error classes with no individual information conatined.