html/input: Lowercase attributes #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes are case-insensitive, and they are conventionally written in lowercase to reduce confusion. It seems this particular example accidentally used the naming of the IDL property (which is different from the DOM attribute). In most cases the only difference is the casing, but in some cases (such as node.className vs "class"), the name is different entirely. In general to avoid confusion, attributes should consistently be written in lowercase.
|
💖 Thanks for opening this pull request! 💖 |
wbamberg
reviewed
Jul 9, 2018
| @@ -4,7 +4,7 @@ | |||
| <div class="username"> | |||
| <label for="uname">Username:</label> | |||
| <input type="text" id="uname" name="uname" required | |||
| minLength="4" maxLength="8" | |||
| minlength="4" maxLength="8" | |||
There was a problem hiding this comment.
I suppose we should fix maxlength at the same time :)
schalkneethling
added
bug
Krinkle
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
wbamberg
pushed a commit
to wbamberg/interactive-examples
that referenced
this pull request
Jul 12, 2018
* upstream/master: (33 commits) Add HTML example for <a> (issue mdn#1014) (mdn#1022) fix(tabbed): load fonts as part of the editor css as @font-face does not work inside shadow dom (mdn#1015) html/input: Lowercase attributes (mdn#1024) Add color-adjust property example (mdn#1008) chore(deps): update dependency eslint to v5.1.0 (mdn#1023) chore(community): add @goodwin64 as contributor (mdn#1021) chore(community): add @dagolinuxoid as contributor (mdn#1020) chore(community): add @arai-a as contributor (mdn#1019) chore(community): add @ro-ka as contributor (mdn#1018) Issue mdn#1013 <style> elements in HTML editor break editor's render method (mdn#1017) chore(deps): update jest monorepo to v23.3.0 (mdn#1012) Issue#946 open links in new tab (mdn#1009) Send metric only during loading event (mdn#1011) fix(performance): only send loading mark inside loading event (mdn#1010) chore(deps): update dependency prettier to v1.13.7 (mdn#1006) fix(address): add name to the provided address (mdn#1004) chore(community): add @Arkangus as contributor (mdn#1002) Correct "expected output" mistake (mdn#1000) fix(performance): send post to kuma for custom ie-load-event-end metric (mdn#1001) chore(deps): update jest monorepo to v23.2.0 (mdn#993) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes are case-insensitive, and they are conventionally written
in lowercase to reduce confusion.
It seems this particular example accidentally used the naming of
the IDL property (which is different from the DOM attribute).
In most cases the only difference is the casing, but in some cases
(such as node.className vs "class"), the name is different entirely.
In general to avoid confusion, attributes should consistently be
written in lowercase.