Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): merge CSS Units group into CSS Values and Units #879

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

chore(css): merge CSS Units group into CSS Values and Units #879

wants to merge 43 commits into from
+85 −133

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 4, 2025 •
edited
Loading

Description

merge CSS Units group and other unit-related groups into, this follows the structure of the specification and mdn web docs

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Values_and_Units
https://drafts.csswg.org/css-values/
https://drafts.csswg.org/css-values-5/

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 4, 2025 14:55
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 4, 2025 14:55
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team January 4, 2025 14:55
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Feb 14, 2025
skyclouds2001 and others added 23 commits February 21, 2025 23:23
@skyclouds2001
chore(css): Update group for CSS Text
1f261e0
@skyclouds2001
chore(css): Update group for CSS Fonts
2138f3e
@skyclouds2001
chore(css): Update group for CSS Animations
49f6c92
@skyclouds2001
chore(css): Fix group for CSS Transitions module (#5)
212baaa
@skyclouds2001
chore(css): Rename CSS Logical Properties to CSS Logical Properties a…
b5af8d8 
…nd Values
@skyclouds2001
feat(css): Update syntax for circle() and ellipse() functions
cf51b7c
@skyclouds2001
feat(css): Add missing rect() and xywh() functions
0e4d6a1
@skyclouds2001
chore(css): Fix group for shape-rendering
729efa9
@skyclouds2001
chore(css): Fix group for clip-rule
faa30d8
@skyclouds2001
chore(css): Rename CSS Positioning group to CSS Positioned Layout gro…
d0c1baf 
…up (#12)
@skyclouds2001
chore(css): Fix group for some CSS Inline module feature
f6693ed
@skyclouds2001
Fix group for CSS Images module (#14)
26ab04c
@skyclouds2001
chore(css): Add CSS Anchor Positioning group (#15)
c9e8272
@skyclouds2001
chore(css): Fox group for CSS Display module features
4616b96
@skyclouds2001
chore(css): Fix group for css env() function
e110015
@skyclouds2001
Update status for page-break-* properties
620041f
@skyclouds2001
chore(css): Fix group key for text-overflow
60987fe
@skyclouds2001
chore(css): Update group for @import
8ec4d72
@skyclouds2001
feat(css): Update syntax for an+b type
34d2220
@skyclouds2001
feat(css): Add css symbols() function
82c1f64
@bsmth @skyclouds2001
chore(ci): remove unused workflows
dad8642
@skyclouds2001
Remove never used CSSOM View group
f1c8abf
@skyclouds2001
chore(css): Remove cross-fade from Filter Effects group (#26)
451acf6
@skyclouds2001
chore(css): Rename CSS Motion Path to Motion Path (#27)
2955efb
@skyclouds2001
feat(css): Update synatx for css zoom property (#28)
746cf77
@skyclouds2001
chore(css): Rename CSS Device Adaptation to CSS Viewport (#29)
fb88a19
@skyclouds2001
style(css): fix feature order (#30)
7e76340
@skyclouds2001
feat(css): Update group value for CSS Lists and Counters group (#31)
2962ec7
@skyclouds2001
feat(css): Update filter-function-list to filter-value-list (#32)
25b0cab
@skyclouds2001
feat(css): Update syntax for text-transform:math-auto (#33)
362d8c8 
* Update syntax for `text-transform:math-auto`

* Update css/properties.json
@skyclouds2001
chore(css): Rename CSS Scrollbars to CSS Scrollbars Styling to match …
3f357be 
…spec (#34)
@skyclouds2001
Update group defnitions for CSS View Transitions (#35)
558001b
@skyclouds2001
feat(css): Add rest standard selectors (#36)
fbb8b0b
@skyclouds2001
feat(css): Add CSS Shadow Parts group to ::part() (#37)
f4e1b8c
@skyclouds2001
feat(css): Update for CSS Generated Content group (#38)
e0949cb
@skyclouds2001
chore(css): Update group of CSS Cascading and Inheritance (#39)
c18fd9d
@skyclouds2001
Merge branch 'main' into merge-unit-group
933f292
skyclouds2001
skyclouds2001 commented Feb 21, 2025
View reviewed changes
pepelsbey
pepelsbey reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the removal of the .github/workflows/codeql.yml is not mentioned/justified in the description, and there are many other changes, too. It seems like the other feature branch (next) got merged here and widened the scope of the PR.

@pepelsbey pepelsbey removed the idle Issues and pull requests with no activity for three months. label Feb 24, 2025
@skyclouds2001
Copy link
Contributor Author

I noticed the removal of the .github/workflows/codeql.yml is not mentioned/justified in the description, and there are many other changes, too. It seems like the other feature branch (next) got merged here and widened the scope of the PR.

guessing that happens due to unexpected merge/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyclouds2001 @pepelsbey @bsmth