Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-spacing-trim property #743

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jun 28, 2024

Description

Chrome supports the text-spacing-trim property as of version 123 (see the ChromeStatus entry).

This PR adds data for the property.

Motivation

Additional details

Related issues and pull requests

BEGIN_COMMIT_OVERRIDE
feat(css): add text-spacing-trim property
END_COMMIT_OVERRIDE

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. Is there a linked content PR for the incoming page?

@chrisdavidmills
Copy link
Contributor Author

Thank you. LGTM. Is there a linked content PR for the incoming page?

Not yet, but there will be shortly.

@bsmth bsmth merged commit bb0a599 into mdn:main Jun 28, 2024
4 checks passed
@caugner
Copy link
Contributor

caugner commented Jul 2, 2024

@chrisdavidmills @bsmth To trigger the release-please PR, make sure to always use conventional commit format for the PR title, i.e. have it start with feat(css): / fix(css): / chore(css):

PS: I have added a COMMIT_OVERRIDE section in the PR description to mitigate this.

@bsmth
Copy link
Member

bsmth commented Jul 2, 2024

PS: I have added a COMMIT_OVERRIDE section in the PR description to mitigate this.

Thank you, I completely forgot about this, and TIL about COMMIT_OVERRIDE.

You can enforce this via rulesets, apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants