Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: descriptions of discrete animation behavior between visible and hidden #690

Merged

Conversation

chrisdavidmills
Copy link
Contributor

Description

In #688, part of the work was to add descriptions of the new specific animation behavior of certain "discrete" animated properties — display, content-visibility, and overlay — when animating from a hidden state or a visible state. However, on talking to some Chrome engineering folks about this, I realized that some of my descriptions were not quite right.

This PR aims to fix those descriptions.

The description I was sent by the Chrome engineering folk is as follows:

"The idea behind "p = 1" is that during transitions between certain values for certain properties which we consider invisible to visible or vice versa, the browser will automatically choose the "visible" option for the duration of the animation it creates.
For example, if you transition from "display:none" to "display:block", the element will be "display:block" for the entire animation created by the transition.
And likewise if you transition from "display:block" to "display:none", the element will be "display:block" for the entire animation created by the transition.
However, if you transition from "display:flex" to "display:block", the element's display value will switch halfway through the animation.
This behavior is applied to content-visibility:hidden, display:none, visibility:hidden, and overlay:none."

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Oct 13, 2023
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit eb3bd6b into mdn:main Dec 28, 2023
4 checks passed
teoli2003 pushed a commit that referenced this pull request Dec 28, 2023
🤖 I have created a release *beep* *boop*
---


## [2.3.2](v2.3.1...v2.3.2)
(2023-12-28)


### Bug Fixes

* descriptions of discrete animation behavior between visible and hidden
([#690](#690))
([eb3bd6b](eb3bd6b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants