Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add conventional commits guideline to the PR template #689

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

OnkarRuikar
Copy link
Contributor

Contributors are not following conventional commits so the releases are not happening frequently. The PR updates PR template and CONTRIBUTING docs.

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Sep 8, 2023

We can also create a workflow to check PR titles when a PR is created, edited, or reopened. We need to create such workflow in each repo where we follow conventional commits because there is no way for contributors to figure out which repo uses such convention.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Oct 13, 2023
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OnkarRuikar - (next up is adding a CODEOWNERS so we get the review auto-assigned 😉)

@bsmth bsmth merged commit e756ea6 into mdn:main Nov 3, 2023
3 checks passed
@OnkarRuikar OnkarRuikar deleted the patch-1 branch November 3, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants