fix: scroll-timeline-axis and scroll-timeline-name are properties #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to latest state of spec, |
github-actions
bot
added
the
idle
teoli2003
approved these changes
Jan 23, 2023
|
Hi! In order to merge this, commits need to be signed: https://docs.github.com/articles/about-gpg/ |
github-actions
bot
removed
the
idle
This should not be a blocker any more |
|
Thank you! |
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#609 incorrectly recorded the
scroll-timelinesyntax as<scroll-timeline-name> || <scroll-timeline-axis>. This is incorrect asscroll-timeline-axisandscroll-timeline-nameare properties and need to be quoted as such.