Recommend AudioNode constructor instead of factory function #7615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-vogler
changed the title
This comment has been minimized.
This comment has been minimized.
files/en-us/web/api/baseaudiocontext/createbiquadfilter/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createbuffersource/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createchannelmerger/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createchannelsplitter/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createconstantsource/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createconvolver/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createdynamicscompressor/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createiirfilter/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createoscillator/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createstereopanner/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createwaveshaper/index.html
Outdated
Show resolved
Hide resolved
sideshowbarker
approved these changes
Aug 5, 2021
files/en-us/web/api/baseaudiocontext/createbiquadfilter/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createbuffersource/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createchannelmerger/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createchannelsplitter/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createconstantsource/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createconvolver/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createdynamicscompressor/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createiirfilter/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createoscillator/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createstereopanner/index.html
Outdated
Show resolved
Hide resolved
files/en-us/web/api/baseaudiocontext/createwaveshaper/index.html
Outdated
Show resolved
Hide resolved
|
Max, really nice work. Thanks much, and congrats on landing your first docs change here — welcome aboard 🎉 |
|
Thanks for the quick merge and applying your suggestions yourself! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7426
Existing docs sometimes recommend the AudioNode factory method, but the constructor should be recommend instead, see #7426.
I added a bunch of smaller clean ups along the way. Feel free to suggest a rewording to the sentences that I used - since the wording is now consistent, I can change it pretty quickly.