Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy-edit fixes for Date.toLocaleString doc #7017

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Copy-edit fixes for Date.toLocaleString doc #7017

merged 1 commit into from
Jul 19, 2021

Conversation

getsnoopy
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

This commit fixes some grammatical and terminology errors on the Date.toLocaleString documentation page.

Issue number (if there is an associated issue)

N/A

Anything else that could help us review it

Nothing.

@getsnoopy
Fix copy errors on Date.toLocaleString page
c1e17ee 
This commit fixes some grammatical and terminology errors on the Date.toLocaleString documentation page.
@getsnoopy getsnoopy requested a review from a team as a code owner July 19, 2021 00:55
@getsnoopy getsnoopy requested review from sideshowbarker and removed request for a team July 19, 2021 00:55
sideshowbarker
sideshowbarker approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes

@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleString
Title: Date.prototype.toLocaleString()
on GitHub

No new external URLs

@sideshowbarker sideshowbarker changed the title Fix copy errors on Date.toLocaleString page Copy-edit fixes for Date.toLocaleString doc Jul 19, 2021
@sideshowbarker sideshowbarker merged commit 7b2a99c into mdn:main Jul 19, 2021
@sideshowbarker
Copy link
Member

Thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getsnoopy @sideshowbarker