-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update device client hint information #6097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no spec, then I think we should remove {{Specifications}}.
300741e
to
6782563
Compare
@Elchi3 OK, this updated and I have added the other screen client hints. It is ready for re-review. There are bits that are "thin" but should be correct (I don't want to go into too much investigation on the deprecated API e.g. Content-DPR). Following a helpful response on WHATWG matrix group I now know that the screen client hints moved to https://wicg.github.io/responsive-image-client-hints/. What it looks like happened is
But Chromium not yet made the change. My assumption is that rather than attempt to rename/merge the new variants on the header we would just create new pages and new BCD entries for them and deprecate the old ones (@ddbeck). Is this correct? What would be the trigger for this? Feels a bit early - not in any browser and there are still questions in the spec. |
This is right. The schema does have a notion of true renames (i.e., prefixes and
For BCD, avoid introducing all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hamish, great work! (again!)
Some nits inline.
If there is no implementation of the new Sec-CH-* headers, then I think documentation work should wait. The spec can change again and so it would be a catch-up game with something that isn't real yet and so just work for us with no user benefit.
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Thanks very much @Elchi3 . Accepted all your commits and integrated your suggestions. Ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👍
This updates DPR HTTP header with directives section, and additional info from the last spec I can find in which it was mentioned (in the next version there is info that says headers were removed to their own specs, but I cannot yet find.
It also adds info about using Vary, and what happens if the value appears multiple times in response. That's from the spec.
I removed info about Accept-CH-Lifetime from this page, as that header is deprecated.
This is part of addressing #1408 and follows on from #5883.
@Elchi3 Feel free to review/merge this. If you don't, I'll continue to add the other device client hints docs until done. But hoping for sanity check. Note, I'm also after advice on how to find the spec for this.