Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing <code> #5096

Merged
merged 1 commit into from
May 20, 2021
Merged

Remove confusing <code> #5096

merged 1 commit into from
May 20, 2021

Conversation

alattalatta
Copy link
Member

What was wrong/why is this fix needed? (quick summary only)

The "a media element" is supposed to mean "a <audio> or a <video> element", not "a <media> element".

MDN URL of the main page changed

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/track

Issue number (if there is an associated issue)

🙅‍♀️

Anything else that could help us review it

🙅‍♀️

@alattalatta alattalatta requested a review from a team as a code owner May 18, 2021 15:45
@alattalatta alattalatta requested review from rachelandrew and removed request for a team May 18, 2021 15:45
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@wbamberg
Copy link
Collaborator

@rachelandrew , was there a reason for not merging this after you approved it?

@rachelandrew rachelandrew merged commit f32732b into mdn:main May 20, 2021
@alattalatta alattalatta deleted the patch-4 branch May 20, 2021 11:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants